Repository navigation
Synchronize terminal mode test - #607
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terminal-size test let the child exit immediately after its second output line. The Process protocol allows queued PTY output to arrive after Exit, when the local terminal is already restored; that valid ordering can produce a second carriage return and make the test fail.
Keep the child alive until the test has observed the resized output, then release it through stdin. Preserve exact output and restored-terminal-mode assertions. Replace output polling with notification, and reap the child on failure. Production code and protocol behavior are unchanged.
Validation: a controlled real-relay diagnostic reproduces the CI output with Exit preceding late output; focused race 50 repetitions, full processbroker tests (including uncached postcommit), vet and naming/docs/CI hygiene pass. Coordinator reviewed the complete diff. Fixes the runtime CI failure observed on #606 without rerunning that failed result or weakening its assertion.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.