Repository navigation
Preserve process cancellation after leader exit - #611
Merged
SaladDay merged 1 commit intoOct 9, 2026
Merged
Conversation
SaladDay
deleted the
aos/preserve-process-cancellation-after-leader-exit
branch
October 9, 2026 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shim loss or an unrecoverable stdin failure selects cancellation, a concurrent leader exit could suppress the remote Cancel request and leave descendants running. Preserve the already-selected cancellation; an exit observed before the loss still leaves normal Session background work running.
Validation: deterministic regressions fail on the old code for both cancellation callers and pass after the fix, with exit-first and live-leader controls; package tests, focused race tests repeated 50 times, build/vet and repository hygiene pass. This fixes cancellation delivery only; remote scope enforcement and public cancellation settlement are separate work.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.