Repository navigation
Change the Code Examples to match the Readme examples #49
Description
The current code examples do not match the Readme Code-Examples and it would be simpler to follow if they are using the same patterns.
Current Examples:
https://github.com/Mom0aut/DynamicRelations/blob/master/testing/src/main/java/at/test/drm/AnnotationTest.java
- AnnotationTest1-3
This should be refactored to be named like at the Readme File:
- PersonEntity
- DogEntity
- etc..
Activity
[-]Change the Code-Examples to match the Readme examples[/-][+]Change the Code Examples to match the Readme examples[/+]cs168898 commentedon Aug 28, 2025
Hello, this is my first time contributing, is it okay if I take this issue? And to clarify, to resolve this issue is to change the class names, file names and import names? Thank you!
Mom0aut commentedon Aug 28, 2025
Hey sure go ahead 🚀
Yes the EntityClasses/Packages should be renamed to better fit the Readme-File
cs168898 commentedon Aug 29, 2025
Hi, can i check if the AnnotationTestRelationDao and AnnotationTestRelation is implemented in the 'testing' directory? Because from my fork it seems like it is not, and if it is not, should I implement it?
Mom0aut commentedon Aug 29, 2025
Hey you dont need to implement the Dao-Methods from Spring. The Spring-Framework does this for you 😄
Here is an simple tutorial about Spring Daos: https://www.baeldung.com/java-dao-pattern
cs168898 commentedon Aug 29, 2025
I see.. Alright, I have created a pull request, let me know if it is what you wanted. If there are any mistakes or any changes, please let me know!
Mom0aut commentedon Aug 29, 2025
There are still some tests failing, you can verify your changes when you run
mvn clean installThe current error from the tests:
Mom0aut commentedon Sep 2, 2025
merged with #52 🚀