Repository navigation
fix: /search crashed because ResultCard used a hook on the server - #34
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hotfix.
/search(Find results and the Ask page) crashed with "Something went wrong" in production since the data saver release (#30):ResultCardcalls theuseLiteUrl()hook but had no"use client", so rendering it on the server threw. Type-check and lint can't see this, and the smoke tests weren't re-run after that release.Fix
ResultCardis now a client component.tests/unit/client-boundary.test.tsfails the build for any file that calls a hook without"use client"(verified: it fails on the broken version).Verified
Locally,
/searchrenders results for three queries (48, 28 and 22 result links) where it previously showed the error page.Under the 20-file guideline on purpose: this is a production outage on the core flow, so it ships alone and first.