Repository navigation
feat(store): built-in node:sqlite, no native module - #25
Merged
Merged
Conversation
…ever compiles anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces better-sqlite3 with node:sqlite behind a small Db wrapper (prepare/exec/pragma/nestable transactions, plain-object rows).
Why: a clean clone on Windows failed npm install because npm ran node-gyp for better-sqlite3 (no Visual Studio). Tried ignore-scripts first; that breaks Linux (esbuild postinstall). Judges must be able to run npm install && npm run demo.
All 255 node tests, 33 web tests and 17 Playwright tests pass. Dockerfile no longer needs a compiler. Decision D20, friction log FL-1.