Skip to content

Colour the Hubs button like the selected tab; frame the deletion dialog in red - #13

Merged
ZmeiGorynych merged 1 commit into
mainfrom
egor/blue-hubs-button
Oct 21, 2026
Merged

ZmeiGorynych merged 1 commit into
mainfrom
egor/blue-hubs-button

Conversation

@ZmeiGorynych

@ZmeiGorynych ZmeiGorynych commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Cosmetic follow-up to #12.

  • The Hubs button gets the selected tab's look (blue --accent background and border, white text), hovered or not.
  • The open Hubs menu goes back to its thin grey border (Frame the Hubs menu and the worktree-deletion dialog in the selected tab's blue #12 framed it 3px blue).
  • The worktree-deletion confirmation is framed 3px in a new --danger red (#f14c4c, the failed-mark red, which now uses the token) instead of blue. Repo-removal and host-action confirmations and the right-click worktree menu keep their thin border.

Tests

  • hubs.spec.ts: the Hubs button's computed background, border and text colours equal the selected repo tab's, before and while hovered; the open menu's border is 1px.
  • sidebar.spec.ts: the deletion dialog is 3px rgb(241, 76, 76) on every side; a repo-removal dialog stays 1px and not red.
  • Full suite: vitest 2422/2422, Playwright 180/180.

Summary by CodeRabbit

  • Style
    • Added a consistent danger color for failed status indicators and worktree-deletion dialogs.
    • Updated Hubs menu buttons to match selected repository and terminal tab styling, including hover states.
    • Applied a thin border to the Hubs menu.
    • Worktree-deletion dialogs now display a prominent 3px red border, while repository-removal dialogs retain their existing border style.

…og in red

The Hubs button gets the selected tab's blue background, border and white
text, hovered or not. The open Hubs menu goes back to its thin grey
border. The worktree-deletion confirmation is framed 3px in a new
--danger red (the failed-mark red), not blue.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: MotleyAI/worktree-term/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 00456e7d-8694-43ce-8f71-1c8e267a569a
📥 Commits

Reviewing files that changed from the base of the PR and between b9206f6 and 7b68f63.

📒 Files selected for processing: 5
  • src/web/main/styles.css
  • test/e2e/contract.ts
  • test/e2e/fixture.ts
  • test/e2e/hubs.spec.ts
  • test/e2e/sidebar.spec.ts
💤 Files with no reviewable changes: 1
  • test/e2e/fixture.ts

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The Hubs menu now matches selected repository tab colors when hovered or unhovered and has a thin border. Worktree-deletion dialogs use a 3px danger-colored border. Failed status markers use the danger color. End-to-end tests and their documentation reflect these styles.

Changes: UI Color and Border Styling

Layer / File(s) Summary
Hubs menu selected-tab styling
src/web/main/styles.css, test/e2e/contract.ts, test/e2e/fixture.ts, test/e2e/hubs.spec.ts
The Hubs menu uses selected-tab colors during hover and when unhovered. Its open menu has a 1px border. Tests check the colors and border, and the unused selected-tab color helper was removed.
Danger borders and failed markers
src/web/main/styles.css, test/e2e/contract.ts, test/e2e/sidebar.spec.ts
Worktree-deletion dialogs use a 3px danger-colored border, while repository-removal dialogs retain 1px borders. Failed status markers use the danger color. Tests and dialog documentation reflect the border changes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 7b68f

The PR contains consistent UI styling updates with matching end-to-end assertions and documentation; no merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes both primary changes: matching the Hubs button to the selected tab and adding a red frame to the deletion dialog.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@ZmeiGorynych
ZmeiGorynych merged commit 2fd1730 into main Oct 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant