Skip to content

P2: fix Android auth, profile saves, and session routing - #3

Open
MphoCodes wants to merge 2 commits into
mainfrom
codex/android-auth-profile
Open

MphoCodes wants to merge 2 commits into
mainfrom
codex/android-auth-profile

Conversation

@MphoCodes

@MphoCodes MphoCodes commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Startup now routes from the persisted Auth session (including delayed identity restoration), initializes missing profile fields, and clears the task on sign-out or account changes. Registration can retry profile setup without creating another Auth account. Profile edits wait for save acknowledgment, preserve existing photos on text-only saves, and show the Auth sign-in email as read-only.

  • Add injectable account/profile/photo gateways and retained ViewModels; reject stale callbacks, destroyed activities, and saved state belonging to another UID.
  • Bootstrap only absent fields in users/{uid} with a transaction/merge. Preserve legacy email, photo references, custom fields, summaries, categories, and historical records. Upload new profile photos under a UID-scoped path without deleting existing objects.
  • Guard all account screens and keep reset/save/upload failures retryable. No whole-window touch blocking or password saved-state retention.

Validation: metadata check, debug APK, instrumentation APK compilation, all 46 JVM/Robolectric tests, and lint pass locally (zero errors, 192 warnings). Independent review findings were fixed with regression tests; follow-up review found no remaining actionable issues. Hosted GitHub Actions passed on final commit 2ca35e21df452c54ce20dc898143f82be38c13fb, including report and APK uploads.

Firebase tests use in-memory gateways and the demo debug configuration; no live Firebase operations, migrations, configuration changes, or rules deployments were performed. Device and isolated Firebase/rules integration checks remain required before production rollout. Process death may discard unsaved drafts or a registration name before bootstrap acknowledgment. iOS remains deferred.

@MphoCodes
MphoCodes marked this pull request as ready for review October 19, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant