Repository navigation
Conversation
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing Android build had a non-executable Gradle 8 wrapper, an unconfigured shell runtime, duplicate alpha dependencies and stale manifest/resource entries. This establishes a reproducible Compose-ready build and CI while retaining the existing View screens and Firebase client configuration.
Task 1 only: AGP 9.3.3, Gradle 9.5.0, JDK 21, built-in Kotlin/Compose compiler 2.4.21, Java/Kotlin bytecode 17, compile SDK 37, minimum 27 and temporary target SDK 34. Target 36/system-bar/Back compatibility belongs to Task 2. Includes the exact version catalog, Firebase BOM/main-module import migration, official checksum-verified wrapper, debug-only Material 3 preview, host/API27 workflows and reproducible setup documentation. No opt-out flags, lint suppression/baseline, production Firebase change, later-stage features or merge.
Base:
codex/android-modernization-specat0239eeb137303134e282be64071a8bde99942288; PR #1 was rechecked open/unmerged before push. This stacked PR contains only Task 1 changes.Validation on JBR 21.0.10/macOS arm64:
./gradlew --no-daemon --stacktrace :app:checkDebugAarMetadata :app:assembleDebug :app:assembleDebugAndroidTest :app:lintDebug :app:testDebugUnitTestpassed on the committed tree (87 tasks, 33s), including a compiled Compose function (JVM major 61 and generated Compose runtime parameters).:app:connectedDebugAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.example.acetimetracker.ExampleInstrumentedTestpassed from the clean export: 1 test on a fresh API 27/Android 8.1 Google APIs ARM64 r3 AVD, emulator 37.2.12 build 16428233 (1m16s). Splash launched, Registration resumed, no AndroidRuntime fatal exception. No credentials entered or Firebase records changed.platforms;android-37.0revision 2 and AGP resolved compile SDK 37 successfully. The specified toolchain pins needed no adjustment.570b8dd0875f75a3985c4d0eb05470cfa0a116d5. Ubuntu 24.04/Temurin 21.0.12.1 host job passed all 87 acceptance tasks in 3m. The separate clean API27/default/x86_64 emulator job passed its one package test (emulator 37.2.12 build16428233; 74 tasks, 3m46s). Official SDK ZIP integrity checks passed in both jobs.Plan rulings:
0723195856401067f7a2779048b490ace7a47d7canda421e43855164a8197daf9d8d40fe71c6996bb0d, preserving the selected families. Both actions resolved and completed successfully in the submitted-head workflow; an incorrect future pin would fail CI resolution.defaultx86-64 image. The submitted-head device job installed and tested that image successfully; an incorrect future image choice would fail the independent device job.The reviewer set aside Task2/later product behavior and release readiness under the approved Task1 scope. These remain unverified by this PR; target34 and retained native warnings make that boundary explicit. No deferred minor review findings.
Limitations: package/arithmetic tests do not cover auth, timer, migration or the later target-36 behavior. Retained native GIF 16KB alignment needs release-stage review. Setup commands and report locations:
docs/development/android-setup.md.