BACK-536 - Add wrapNavigationToSearch config to opt out of the boundary search handoff - #770
Closed
kossakovsky wants to merge 1 commit into
Closed
Conversation
…ry search handoff In the TUI, pressing j on the last row or k on the first row (or k at the top of the focused detail pane) hands focus to the search input. The wrap is deliberate (back-399), but it surprises vim-style navigation: j/k are expected to stay inside the list, and / and Ctrl+F already focus search directly. Add an opt-out config key, wrapNavigationToSearch (default true), that keeps today's behavior by default and, when false, stops the handoff in the task list, the detail pane, and the kanban board (including empty columns). With the handoff disabled, boundary navigation falls back to the circular wrap both views used before back-399. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kossakovsky
force-pushed
the
tasks/back-536-wrap-navigation-to-search
branch
from
July 22, 2026 14:13
5b8481a to
3a4486f
Compare
MrLesk
added a commit
that referenced
this pull request
Aug 7, 2026
Closes #768. Supersedes #770's config-key approach per maintainer decision. At list/board boundaries, `j`/`k` previously handed focus to the search input (deliberate in BACK-399, surprising for vim users). Decided behavior, no new config key: `j`/`k` now stop at boundaries (no wrap, no handoff) while the arrow keys keep the search handoff, on the task list, the detail pane, and the board including empty columns; `/` and Ctrl+F are unchanged. Implementation splits the shared bindings into arrow/vim families with one shared boundary resolver; the board's two screen handlers collapse into one (net −23 lines in board.ts). Filter popups and pickers keep circular wrap for both families. Verification: behavior tests driven by real key events with a mutation control (forcing vim to hand off fails 5 tests), plus real-PTY passes on all surfaces whose control scripts fail against pre-fix main. Full suite 1951 pass / 0 fail. Independently reviewed with no blocking findings, including a fork-source analysis confirming no double-scroll in the detail pane and intact picker wrapping.
Owner
|
Alex's agent: Closing this one — the underlying request (#768) shipped on main via #866, but with a different shape than proposed here: rather than adding a config key, j/k now simply never enter the search input at boundaries while the arrow keys keep the handoff, so both vim and regular users get sensible behavior with no new configuration surface. Thanks for the clean implementation and for offering to rescope — the boundary-site map in your diff was genuinely useful when building the shipped version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the TUI, pressing
jon the last row orkon the first row (orkat the top of the focused detail pane) hands focus to the search input. The wrap is deliberate (back-399), but it surprises vim-style navigation:j/kare expected to stay inside the list, and/andCtrl+Falready focus search directly.This adds an opt-out config key that keeps today's behavior by default:
wrapNavigationToSearch(boolean, defaulttrue), available throughbacklog config get/set/listand documented in ADVANCED-CONFIG.mdfalse, the handoff stops in the task list, the detail pane, and the kanban board (including empty columns)Related Issue or Task
Closes #768
Backlog task: BACK-536
Task Checklist
backlog/tasks/Testing
bunx tsc --noEmit— passedbun run check .— passed (323 files)bun test— 1670 passed + 2 intentional skips / 0 failed (187 files)task-viewer-boundary-navigation.test.ts,resolveBoardBoundaryToSearchcases inboard-ui.test.ts, and aconfig get/set/listround-trip for the new key