Repository navigation
Run continuous CI on dev pushes and pull requests - #518
Merged
Merged
Conversation
The `continuous` workflow triggered on `push` only, which never fires for pull requests opened from forks — so fork PRs were never compiled or packed before review. Scope the push trigger to `dev` and add a `pull_request` trigger, matching `mudblazor-ci.yml` in this repo and the CI workflows in MudBlazor/MudBlazor and MudBlazor/TryMudBlazor. This also stops `continuous` from running on every internal branch push and on tag pushes, where it duplicated the build already performed by `release`. The trigger is declared in the NUKE `[GitHubActions]` attribute, so `build/Build.cs` is updated alongside the generated YAML to keep the two in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuous.ymltriggers onon: [push]with nopull_requesttrigger. Apushevent never fires for a pull request opened from a fork, so fork PRs reach review without ever being compiled or packed.[push]also matches every branch and every tag. Recent run history showscontinuousfiring on tag4.3.0alongsiderelease.yml— two concurrent runs building the same commit.Note that
mudblazor-ci.ymlin this repo already uses the correct shape (push: branches: [dev]+pull_request:);continuous.ymlwas simply never updated to match.One of three matching PRs closing the same gap across the org — see MudBlazor/ThemeManager#47 and MudBlazor/MudBlazor.Icons#42.
Change
Because the workflow is generated from the NUKE
[GitHubActions]attribute,build/Build.csis updated in the same commit so a future regeneration doesn't silently revert the trigger. NUKE rejects mixing shorthandOnwith the expandedOn*properties, so both triggers are branch-scoped viaOnPushBranches/OnPullRequestBranches.release.yml,codeql.yml,mudblazor-ci.yml, andmudblazor-auto-merge.ymlare untouched.