Repository navigation
Conversation
| @@ -29,9 +29,6 @@ jobs: | |||
| BOS_STORAGE_ORIGIN: ${{ vars.BOS_STORAGE_ORIGIN || 'https://upload.everything.dev' }} | |||
| BOS_STORAGE_API_KEY: ${{ secrets.BOS_STAGING_STORAGE_API_KEY }} | |||
| RAILWAY_TOKEN: ${{ secrets.RAILWAY_STAGING_TOKEN }} | |||
There was a problem hiding this comment.
Makes sense to keep the workspace token out of staging. One side effect: without it the deploy leg can't repoint the service source, so staging falls back to a plain redeploy with the "service source was not repointed" notice (the run before c768e66 shows it). The source is still pinned to rc.29 from last night's run, so when the rc.30 bump lands, staging will publish rc.30 config but keep pulling the rc.29 image until someone repoints it in Railway. Could you note that in the PR, or add "repoint staging's source by hand" to the upgrade steps? cc @itexpert120 since he added these lines yesterday.
| if (file === "staging.yml" && /secrets\.RAILWAY_TOKEN\b/.test(text)) { | ||
| problems.push(`${file}: reads secrets.RAILWAY_TOKEN, production's Railway token`); | ||
| } | ||
| if (file === "staging.yml" && /^\s*RAILWAY_API_TOKEN\s*:/m.test(text)) { |
There was a problem hiding this comment.
This only catches the unquoted RAILWAY_API_TOKEN: key. "RAILWAY_API_TOKEN": …, echo "RAILWAY_API_TOKEN=${{ secrets.RAILWAY_STAGING_API_TOKEN }}" >> $GITHUB_ENV, or an inline RAILWAY_API_TOKEN=… pnpm run bos deploy would all get through. Maybe also match the secret, like the secrets.RAILWAY_TOKEN rule above, e.g. /secrets\.RAILWAY_\w*API_TOKEN\b|\bRAILWAY_API_TOKEN\b/, with a test for the = form?
| BOS_STORAGE_ORIGIN: ${{ vars.BOS_STORAGE_ORIGIN || 'https://upload.everything.dev' }} | ||
| BOS_STORAGE_API_KEY: ${{ secrets.BOS_STAGING_STORAGE_API_KEY }} | ||
| RAILWAY_TOKEN: ${{ secrets.RAILWAY_STAGING_TOKEN }} | ||
| RAILWAY_API_TOKEN: ${{ secrets.RAILWAY_STAGING_API_TOKEN }} |
There was a problem hiding this comment.
The RAILWAY_STAGING_API_TOKEN secret is still in the repo; last night's run shows it's set. Worth deleting it, and revoking the token in Railway, so nothing can pick it up again.
No description provided.