Skip to content

iterateNestedRecords bool on EnumerateAssetLinks - #701

Merged
Noggog merged 1 commit into
devfrom
EnumerateAssetLinks-nested-bool
Oct 5, 2026
Merged

Noggog merged 1 commit into
devfrom
EnumerateAssetLinks-nested-bool

Conversation

@Noggog

@Noggog Noggog commented Oct 2, 2026

Copy link
Copy Markdown
Member

No description provided.

@Noggog
Noggog requested a review from Elscrux October 2, 2026 02:16
@Noggog

Noggog commented Oct 2, 2026 •

Copy link
Copy Markdown
Member Author

@Elscrux Check the Mod_ShallowWalksGroupsButExcludesCellContents unit test and see if that is the behavior you were expecting or not. Can also have it just return nothing when called on a mod in off mode

I guess I'd say yes, as that's the behavior of EnumerateFormLinks and such to dip into the first layer of records when called on the mod

@Elscrux Elscrux left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I could properly run it, maybe something with my setup

System.TypeInitializationException: The type initializer for 'Mutagen.Bethesda.Plugins.Records.ModFactory' threw an exception.
 ---> System.TypeLoadException: Method 'EnumerateListedAssetLinks' in type 'Mutagen.Bethesda.Fallout3.Fallout3Mod' from assembly 'Mutagen.Bethesda.Fallout3, Version=0.55.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.

But I looked at the tests and it looks like it behaves just like I imagine, thank you!

@Noggog

Noggog commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Hmm, are we sure it's not some local build artifact at play? Does seem odd that it's fo3 related. Im guessing you're doing skyrim work?

@Noggog

Noggog commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

I think it looks good, ill merge and let me know if it still happens on the official nightly build

@Noggog
Noggog merged commit 5ac2183 into dev Oct 5, 2026
2 checks passed
@Noggog
Noggog deleted the EnumerateAssetLinks-nested-bool branch October 5, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants