Repository navigation
Conversation
- Read complete BA2 and BSA payloads with ReadExactly - Correct the same read assumption in the existing BSA stream test
- Reuse the BSA fixture and add general-file and texture BA2 fixtures - Verify complete payloads when streams return at most two bytes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several
CA2022warnings by replacing singleReadcalls withReadExactlywhen reading BA2 and BSA payloads.This also fixes a potential short-read bug. It should be fairly rare in practice, as it only occurs when the underlying stream returns fewer bytes than requested before reaching EOF, but
Stream.Readdoes allow this behavior.Assuming short reads were never intended here, this does not change the behavior of successful reads.