Repository navigation
Add missing unit tests for cargo-audit-gate and image-remote-patterns - #2094
Merged
Merged
Conversation
|
@chrizand9-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing unit test coverage flagged in #2053 and #2052.
scripts/ci/cargo-audit-gate.test.mjs: coversevaluateCargoAudit's blocking, ignored, and stale-ignore classification, plus warning-only entries and error paths, following the existingnpm-audit-gate.test.mjsconventions (node:test).frontend/src/lib/image-remote-patterns.ts/.test.ts: the**.ipfs.iopattern matched any number of subdomain levels under ipfs.io (unbounded), contradicting the module's own "wildcards are intentionally avoided" intent. Scoped it to*.ipfs.io(a single subdomain level, matching the typical<cid>.ipfs.iogateway form) and added a vitest unit test covering the pattern list and the scoping fix.Closes #2053
Closes #2052