Repository navigation
test: cover required-checks comparison; flag 2051/2049 status - #2095
Merged
aji70 merged 1 commit intoOct 20, 2026
Merged
Conversation
|
@lonerthefirst3-sudo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/ci/verify-required-checks.test.mjs, anode:testsuite coveringverifyLocal,parseWorkflow/branchMatches, anddiffRemotefromscripts/ci/verify-required-checks.mjs— job name/context mismatches, missing workflow/job,continue-on-error, job-levelif:, paths filters, branch-filter exclusion, undocumented/duplicate contexts, ambiguous contexts, and the remote diff helper.backend/src/plans/plans.controller.spec.tscovering request parsing and service delegation for everyPlansControllermethod. No gap found, so no duplicate spec added here — left a comment on the issue explaining this.require_authorizeddoes not exist anywhere in the tree (contracts/myfans-lib/src/lib.rsonly definesMyFansErrorand aResultalias; consumers callAddress::require_auth()directly). Left a comment on the issue flagging this rather than fabricating a new helper out of scope for a test-coverage issue.Closes #2051
Closes #2050
Closes #2049
Test plan
scripts/ci/verify-required-checks.mjsand.github/required-checks.jsonto understand the comparison logic before writing the testnode:test+node:assert/strictstyle used by sibling files (npm-audit-gate.test.mjs,audit-gates.test.mjs)node --test scripts/ci/verify-required-checks.test.mjs(not run in this environment; please run in CI)