README: this repo's tokens.json is the source, built by scripts/build-design-package.mjs - #4
Closed
TheBitcoinBackup wants to merge 1 commit into
Closed
TheBitcoinBackup wants to merge 1 commit into
TheBitcoinBackup wants to merge 1 commit into
Conversation
…-design-package.mjs Texts only, from the 28 Sept texts update (drafts reviewed by the admin session). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closed on Quentin's instruction (28 Sept). README.md is generated by scripts/build-design-package.mjs, so editing it directly fails rebuild-check, as it should. The wording goes into the template in the next design release pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo:
MyFirstBitcoin/mfb-design(owner: Quentin (brand changes: Patrick or Quentin)). Base:masterat06180e1(fetched 2026-09-28).Files:
README.md.The README said the package is generated from "the canonical tokens.json (Figma → sync-brand.js)". Since the move on 27 and 28 Sept, this repo's
tokens.jsonis canonical. It changes by pull request and is built byscripts/build-design-package.mjs, and Figma is only watched.Not ready to merge as is:
rebuild-checkfails, and rightly.README.mdis a generated file:scripts/build-design-package.mjs(section 7) writes it, and it ships in the package (filesinpackage.json). This pull request edits only the generated copy, so a fresh build differs from it. The same wording has to go into that template, and the script's own comment says rewording the published README belongs in a release pull request. That choice is Quentin's, so the template is not changed here: either move this wording into the template in a release pull request, or close this one.Checked against
masterat06180e15631d4dd8ad34d50727d0b39a7b796831on 28 Sept.🤖 Generated with Claude Code