Conversation
Collaborator
Author
|
@harrymove-ctrl this is approved on |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
WALM-685 — https://linear.app/mysten-labs/issue/WALM-685/reviewed-main-snapshot-is-missing-the-plugin-security-fixes-from-dev
What changed?
mcpPackageVersioninpackages/mcp/plugin/plugin.jsonis0.0.14-dev.6, not0.0.14-dev.2.## 0.0.14changelog entries (package and docs) name that pin.dev.2has noconsent.jsormemory-policy.js.Why is this needed?
Marketplace installs from public
dev. The pin0.0.14-dev.2ships an MCP server without the WALM-642 secret-exclusion and consent modules.0.0.14-dev.6has them. Packageversionstays0.0.14so the pin remains a prerelease of that release.Scope
Point the plugin launcher at the published build that contains consent and memory policy.
Out of scope
0.0.14-rc.1waits until #986 merges. This PR does not publish.How was this tested?
Commands:
node scripts/verify-manual-sdk-release.mjs;node --test packages/mcp/test/trusted-launcher.test.mjs(29 pass).How can the reviewer verify it?
packages/mcp/plugin/plugin.jsonmcpPackageVersionis0.0.14-dev.6.versionis still0.0.14.node scripts/verify-manual-sdk-release.mjspasses.Risks and dependencies
New installs from
devwill npm-install0.0.14-dev.6into~/.memwal/runtime. Machines that already installeddev.2keep that runtime until the version directory changes.Author checklist