Conversation
harrymove-ctrl
left a comment
harrymove-ctrl
left a comment
Collaborator
There was a problem hiding this comment.
The feature design, types, offline mock, and documentation for listMemories() look great and address WALM-388 cleanly.
Please rebase onto current dev — there is a small conflict in packages/sdk/src/memwal.ts because PR #902 just landed on dev. Once rebased, this is ready to approve.
Recall is similarity-ranked and limit-bounded, so a write can't be
confirmed and a namespace can't be counted. listMemories() wraps the
existing GET /v1/owners/{owner}/memories and reuses resolveOwner().
Metadata only: no blob fetch, no decrypt.
The relayer has no namespace filter, so the optional namespace is
applied client-side; a filtered page can be empty while has_more is
true. Tombstone fields default for relayers older than WALM-363.
nikola0x0
force-pushed
the
nikolale/walm-388-no-operation-to-list-stored-blobs-writes-are-unauditable-and
branch
from
September 25, 2026 06:47
7e0fcff to
aa42596
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recall is similarity-ranked and limit-bounded, so a write cannot be confirmed and a namespace cannot be counted. This adds
listMemories({ cursor?, limit?, namespace? })over the existingGET /v1/owners/{owner}/memories(WALM-295), reusingresolveOwner()likelistNamespaces().preview; userecall()for content.namespaceis filtered client-side because the relayer has no namespace filter. A filtered page can be empty whilehas_moreis true; documented.deleted/must_resyncdefault to[]/falsefor relayers older than WALM-363.MemorySummary,DeletedMemorySummary,MemoriesResult,ListMemoriesOptions.docs/sdk/api-reference.md.Out of scope: the
memwal_listMCP tool (needs the SDK published first), a server-side?namespace=filter, the mock client.Test
test/list-memories.test.mjs(9 tests). 148/148 pass.test/e2e/live.e2e.mjs, dev relayer): writes 3 memories to a fresh namespace, pages them withlistMemories({ namespace }), checks exactly those 3 blob ids andlistNamespaces()memory_count: 3. 12/12 pass.Part of WALM-388.