Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
WALM-710 — https://linear.app/mysten-labs/issue/WALM-710/bug-openclaw-memory-search-memory-store-ignore-the-calling-agent-per
GH #1017 — #1017
What changed?
memory_searchandmemory_storeregister as OpenClaw tool factories and take the namespace fromctx.sessionKeyviaresolveAgent.agent:main:) still usesdefaultNamespace.namespace.devis already ahead ofmain).Why is this needed?
The tools trusted the model's
namespaceargument and fell back to the main agent's memory. A sub-agent that omitted it, or was told to passdefault, could read and write the main namespace. The hooks already scoped by session. The tools did not.Scope
Pin the two agent tools to the calling agent's namespace.
Out of scope
No allowlist of extra namespaces. Hooks still derive the namespace the same way. No relayer change.
How was this tested?
Commands:
pnpm --filter @mysten-incubation/oc-memwal test(32 passed).node scripts/verify-manual-sdk-release.mjspassed.How can the reviewer verify it?
agent:support-bot:...,memory_searchwith no namespace recallssupport-bot, notdefault.namespace: "default"returnsnamespace_rejectedand does not call the client.agent:main:or a missing session key still usesdefaultNamespacewhen namespace is omitted.agent:Researcher:...may passResearcher(legacy) and otherwise usesresearcher.Risks and dependencies
Agents that relied on the model passing another namespace will now be rejected. That is the isolation fix. OpenClaw must call the tool factory with the session context (
openclaw@2026.9.6).Author checklist