Skip to content

docs: show recall() scoringWeights on SKILL.md (WALM-616) - #899

Open
HoangDucBach wants to merge 2 commits into
devfrom
wyner/walm-616-bug-recall-cannot-pass-scoringweights-recency-ranking-only
Open

HoangDucBach wants to merge 2 commits into
devfrom
wyner/walm-616-bug-recall-cannot-pass-scoringweights-recency-ranking-only

Conversation

@HoangDucBach

@HoangDucBach HoangDucBach commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Ticket

WALM-616 — https://linear.app/mysten-labs/issue/WALM-616
GH #708 — #708

What changed?

Why is this needed?

Agents reading SKILL.md still cannot see scoringWeights on recall(). The SDK gap is already closed; this is the remaining advertised contract.

Scope

SKILL.md only. No MCP memwal_recall change (WALM-428).

Out of scope

  • MCP sort=recent (WALM-428)
  • Python recall() still does not send scoring_weights

How was this tested?

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not applicable

Commands: npm test --prefix packages/sdk (includes recall sends scoringWeights as snake_case scoring_weights)

Verify

  • recall({ query, scoringWeights: { semantic: 1, recency: 0.5 } }) POSTs scoring_weights
  • Omit scoringWeights and the body has no scoring_weights key
  • MCP memwal_recall schema unchanged

Risks

Docs-only. No runtime change.

Author checklist

  • I ran the relevant tests (npm test --prefix packages/sdk)
  • I did not bump the unpublished 0.1.7 changelog (behavior already in 0.1.6)
  • No secrets committed

The TypeScript gap already shipped in 0.1.6. Agent docs still listed the old RecallOptions, which is how GH #708 concluded recency ranking was unreachable.
@HoangDucBach
HoangDucBach requested a review from ducnmm September 11, 2026 04:37

@ducnmm ducnmm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Docs-only: SKILL.md now lists sort and scoringWeights on recall() / RecallOptions. That matches origin/dev (recall() already POSTs scoring_weights since 0.1.6). No dump needed. MCP memwal_recall is untouched.

Issue counts by severity

  • bugs: 0
  • suggestions: 1
  • nits: 0

Comment thread SKILL.md
namespace?: string;
maxDistance?: number;
sort?: "relevance" | "recent";
scoringWeights?: ScoringWeights; // sent as scoring_weights; omit to keep cosine order

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] scoringWeights?: ScoringWeights is the advertised contract this ticket is closing, but ScoringWeights is never defined in SKILL.md. Agents reading only this file still cannot see { semantic?, recency?, recencyHalfLifeDays?, importance? }.

Suggestion: Add the ScoringWeights interface next to RecallOptions (same fields as packages/sdk/src/types.ts). A one-liner that sort: "recent" is newest-wins (over-fetch then write-time) and scoringWeights only re-ranks the cosine window would match the SDK docs.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ScoringWeights next to RecallOptions, plus the sort vs weights one-liner.

Agents reading only this file still could not see the weight fields.
@HoangDucBach
HoangDucBach requested a review from ducnmm September 11, 2026 09:21

@ducnmm ducnmm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, documentation updates match the SDK options.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants