-
Notifications
You must be signed in to change notification settings - Fork 23
xnetcdf and 2-d lat/lon coordinates
#963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidhassell
wants to merge
30
commits into
NCAS-CMS:main
Choose a base branch
from
davidhassell:rotated-pole
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
c44eacb
dev
davidhassell 5e546a5
dev
davidhassell 813f6d5
dev
davidhassell f35b817
dev
davidhassell 77db7dc
dev
davidhassell fe45daa
dev
davidhassell ed250fe
dev
davidhassell 9a0eca0
dev
davidhassell c16098b
dev
davidhassell dc54d9a
dev
davidhassell c8d74d1
dev
davidhassell 7309ac3
dev
davidhassell 4b33d7e
dev
davidhassell a489a9d
dev
davidhassell 0a88711
dev
davidhassell 8ac2b98
dev
davidhassell 51bfa22
dev
davidhassell f5f9ea7
dev
davidhassell 9e0bdbf
dev
davidhassell 2dc12d7
dev
davidhassell 8aaac63
dev
davidhassell 6546ebd
dev
davidhassell 21492e6
dev
davidhassell 13dabc9
dev
davidhassell 6a2151b
dev
davidhassell 885ade5
dev
davidhassell 34ea251
dev
davidhassell 7ad5020
dev
davidhassell 94e2671
dev
davidhassell 37d872b
dev
davidhassell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -172,6 +172,7 @@ | |
| ScipyNetcdfFileArray, | ||
| SubsampledArray, | ||
| UMArray, | ||
| XnetcdfArray, | ||
| ZarrArray, | ||
| ) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,15 @@ | ||
| import cfdm | ||
|
|
||
| from ...mixin_container import Container | ||
| from .mixin import ActiveStorageMixin | ||
|
|
||
|
|
||
| class H5netcdfArray( | ||
| ActiveStorageMixin, | ||
| Container, | ||
| cfdm.H5netcdfArray, | ||
| ): | ||
| class H5netcdfArray: | ||
| """A netCDF array accessed with `h5netcdf` using the `h5py` backend. | ||
|
|
||
| .. versionadded:: 3.16.3 | ||
|
|
||
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| class DeprecationError(Exception): | ||
| """Deprecation error.""" | ||
|
|
||
| raise DeprecationError( | ||
| f"{self.__class__.__name__} was deprecated at version NEXTVERSION " | ||
| "and is no longer available. Use XnetcdfArray instead." | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,11 @@ | ||
| import cfdm | ||
|
|
||
| from ...mixin_container import Container | ||
| from .mixin import ActiveStorageMixin | ||
| class NetCDF4Array: | ||
| """A netCDF array accessed with `netCDF4`.""" | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| class DeprecationError(Exception): | ||
| """Deprecation error.""" | ||
|
|
||
| class NetCDF4Array( | ||
| ActiveStorageMixin, | ||
| Container, | ||
| cfdm.NetCDF4Array, | ||
| ): | ||
| """A netCDF array accessed with `netCDF4`.""" | ||
| raise DeprecationError( | ||
| f"{self.__class__.__name__} was deprecated at version NEXTVERSION " | ||
| "and is no longer available. Use XnetcdfArray instead." | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,15 @@ | ||
| import cfdm | ||
|
|
||
| from ...mixin_container import Container | ||
| from .mixin import ActiveStorageMixin | ||
|
|
||
|
|
||
| class PyfiveArray( | ||
| ActiveStorageMixin, | ||
| Container, | ||
| cfdm.PyfiveArray, | ||
| ): | ||
| class PyfiveArray: | ||
| """A netCDF array accessed with `pyfive`. | ||
|
|
||
| .. versionadded:: 3.20.0 | ||
|
|
||
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| class DeprecationError(Exception): | ||
| """Deprecation error.""" | ||
|
|
||
| raise DeprecationError( | ||
| f"{self.__class__.__name__} was deprecated at version NEXTVERSION " | ||
| "and is no longer available. Use XnetcdfArray instead." | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,15 @@ | ||
| import cfdm | ||
|
|
||
| from ...mixin_container import Container | ||
|
|
||
|
|
||
| class ScipyNetcdfFileArray( | ||
| Container, | ||
| cfdm.ScipyNetcdfFileArray, | ||
| ): | ||
| class ScipyNetcdfFileArray: | ||
| """A netCDF-3 array accessed with `scipy.io.netcdf_file`. | ||
|
|
||
| .. versionadded:: 3.20.0 | ||
|
|
||
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| class DeprecationError(Exception): | ||
| """Deprecation error.""" | ||
|
|
||
| raise DeprecationError( | ||
| f"{self.__class__.__name__} was deprecated at version NEXTVERSION " | ||
| "and is no longer available. Use XnetcdfArray instead." | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
umfiveoptional for cf-python as it now is for cfdm? In which caseumfiveis also relevant when it comes to reading. So it's more a team effort between xnetcdf and umfive, really.