Skip to content

Add timeout field to Query#4

Closed
not43s wants to merge 1 commit into
NCATSTranslator:mainfrom
not43s:add-query-timeout-parameter
Closed

Add timeout field to Query#4
not43s wants to merge 1 commit into
NCATSTranslator:mainfrom
not43s:add-query-timeout-parameter

Conversation

@not43s

@not43s not43s commented Jul 17, 2026

Copy link
Copy Markdown

No description provided.

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@tokebe

tokebe commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi @not43s, this would bring TOM out of alignment with TRAPI 1.6. In TRAPI 2.0 there will be an official format for setting a custom timeout. Translator will be moving to TRAPI 2.0 after the refactor is pushed to Production.

For your use case, I would recommend making a subclass of Query:

from translator_tom import Query

class QueryWithTimeout(Query):
    timeout: int | None = None

and then using that subclass internally for your code.

@tokebe tokebe closed this Jul 23, 2026
@not43s

not43s commented Jul 23, 2026

Copy link
Copy Markdown
Author

Apologies. It seems I am getting up to speed during a significant migration. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants