Repository navigation
Conversation
…en (#394) Adds a public GET /communities/by-organization/{organizationId} that the auth plugin's joined screen reads for "Visit {community}" and channels, and points the onboard config from everything-dev #662 at it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #394 and #399. Draft until the everything-dev release that includes NEARBuilders/everything-dev#662 (merged, not yet in a release; latest is rc.27). After that, City Node needs the
platformpin bump to rc.28.What this does
onboard.community.urlauth variable. After a code is redeemed, the joined screen fetches that app path with the redeemed organization ID and shows Visit {community} plus the community's channels.GET /communities/by-organization/{organizationId}(getOnboardCommunity) returns{ name, href, channels }:parentIdin the link;bos.app.tssetsonboard.community.urlto/api/communities/by-organization/{organizationId}./build,/dashboard,/explore) already fit City Node, so they're left as is.MembershipEndederror and clearing the stale active organization. City Node needs no code for it, only the pin bump.Tested
pnpm typecheck,pnpm lint, api tests (435) and ui tests (1126) pass./api/communities/by-organization/<org>returns the name,/n/<slug>and both channels;Before marking ready
pnpm bos upgradeScreenshots
No visible change in City Node yet. This PR adds an API route and auth config; the joined screen that uses them is the upstream auth plugin's page, which only gains "Visit {community}" and channels after the rc with everything-dev#662 is pinned. Joined-screen screenshots (with channels, without channels, and 375px) will be added with the pin bump, before this leaves draft.