Repository navigation
feat: second stability declaration (ADR 0036) - #57
Merged
Merged
Conversation
…ody pinned, clearer version errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the second stability declaration (ADR 0036). The formats added in Phases 1–3 become stable and are pinned by golden fixtures.
permesh mcp, starter templates and human-readable output stay experimental.permesh.yamlcheckandprofilessections;status;version: 2;profile_checkandprofile_suggestresults v1;permesh_access_planv1, including execution plans;access_plan,access_verifyandaccess_reviewresults andindex.jsonv1;check,profile,accessandinit --starter.version: 1. Nothing writes it by default, and leaving it out means 1.people/bob.yaml: format version 2 is newer than this Permesh reads (version 1); upgrade Permesh.index.jsonis now{"access_review_index_version": 1, "plans": [...]}. Any other shape is refused with exit 2 before anything is written.crates/permesh-cli/tests/fixtures/stable/and are checked bytests/stable_formats.rs. They compare exactly, with these exceptions:filespaths compare with/separators.summary,message, the suggest draft) isn't frozen.PERMESH_BLESS=1(see the fixtures README).docs/stability.mdgains the Stable rows and a "Human-readable output" section. The "experimental" labels are removed from the check, notifications, profiles and access-plan docs; ADRs 0032–0034 have updated Status lines. CHANGELOG and ROADMAP are updated too.Validation
cargo test --workspace: 722 passed, 0 failed.cargo clippy --workspace --all-targets --all-features -- -D warnings, fmt,cargo denyandscripts/check_docs.pyare clean.git grep:Deferred minors
index.jsonrefusal message doesn't name the directory or the starter CI remedy (re-run the PR plan job).access movefixture.checkresult is pinned only with--no-notify.profile suggestdraft re-load assertion is weak.