Repository navigation
Review new PRs. Fix "Show JSON Viewer" docking panel #225
Description
Hi @SinghRajenM
I have created a couple of PRs for JSONViewer Notepad++ plugin.
I see that you're the only contributor who was active lately,
so maybe you can help me with reviews and merges 😊?
It's all started with the fact that "Show JSON Viewer" feature does show a docking panel with parsed JSON
but the panel is inactive, half visible and is basically broken (but I do see the content of JSON in it).
NPPJSONViewer v2.1.1.0
Preview of what I see:
Notepad++ v8.8.6 (64-bit)
Build time: Oct 7 2025 - 13:44:28
Scintilla/Lexilla included: 5.5.7/5.4.5
Boost Regex included: 1_85
I decided to take a look and fix that.
Turned out that the problem stems from outdated plugintemplate files which are copied into local external/npp
The simplest fix is to update just the DockingDlgInterface.h - uncomment parameter in virtual INT_PTR CALLBACK run_dlgProc(UINT message, WPARAM /*wParam*/, LPARAM lParam) on line DockingDlgInterface.h:74. I guess commented parameter messes up the virtual table or how virtual function calls are resolved.
Anyways, I went further and decided to update all external/npp files.
I have 2 options for the fix (see which one you like more. I personally prefer the 2nd option (submodule)):
- Fix "Show JSON Viewer" docking/dialog panel UI #222
Here I just update all external/npp files and fix JSONViewer code where needed - Migrate from copies from external plugintemplate to git submodules #223
Alternative version where I remove all external/npp files and take dependency on plugintemplate as git submodule
Also, maybe you can add me as a Collaborator 😊?
Activity
[-]Review new PRs. Fix "Show JSON Viewer" feature UI[/-][+]Review new PRs. Fix "Show JSON Viewer" docking panel[/+]AntonDevil commentedon Oct 23, 2025
Last sync of plugintemplate was done on Nov 12, 2016 in
JSON-Viewer:0106f2abSyncing
JSON-Viewerwithplugintemplate:16152b80 "Notepad++ Plugin Template v3.1 Release"Since then there were a couple of patches made for current master (
JSON-Viewer:aed958ab) for files:Patches since then:
The following links are from
plugintemplate:16152b80 "Notepad++ Plugin Template v3.1 Release" on Sep 16, 2016_countof - fixed to
MAX_PATHin the latest revisionwarnings fix - no warning without this fix in the latest revision
typedef HRESULT - added in the latest revision
warnings fix - no warning without this fix in the latest revision
sprintf_s - migrated to
std::wstringin the latest revisionwarnings fix - no warning without this fix in the latest revision
The rest of the files are the same between the current master and the last sync.
I think none of these patches are needed anymore and its better not to touch these files at all,
but take a dependency on plugintemplate and sync when needed.
Here is the link for the latest revision of
plugintemplate:426b36a3 on Oct 1, 2025for convenience or 3-way compare:
AntonDevil commentedon Nov 11, 2025
Hi @SinghRajenM
Any thoughts on subject?
Docking panel is kind of broken on current versions of npp.
SinghRajenM commentedon Mar 19, 2026
Closing as merged via: #223