fix(cli): forward OpenClaw arguments unchanged - #477
Conversation
Signed-off-by: Elyas Mehtabuddin <emehtabuddin@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe OpenClaw launcher now uses ChangesOpenClaw command forwarding
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The launcher now preserves forwarded OpenClaw arguments while keeping the default interactive command unchanged; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Switchyard currently starts this command:
The launcher inserts
chatbefore every forwarded argument, so OpenClaw receives the root--versionoption under thechatsubcommand instead of unchanged after the executable.Fix
Arguments after
--now form the complete OpenClaw argument list. With no forwarded arguments, the launcher still startsopenclaw chat, so ordinary interactive launches do not change.Callers that intend to pass chat-specific options now include the subcommand explicitly:
Compatibility note: a caller that relied on the launcher to insert
chatbefore forwarded options must now forwardchatexplicitly. Launches without forwarded arguments are unchanged.Evidence
Testing
uv run pytest tests/test_launchers.py -qruns the parser-to-command regression and reports12 passed.Fixes: ba72705
Summary by CodeRabbit
Bug Fixes
Tests