Skip to content

fix: correct NoReturn annotations for normal-returning functions #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct NoReturn annotations for normal-returning functions #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions bobber/bobber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
from bobber.lib.analysis import parse_results
from bobber.lib.system.file_handler import create_directory
from bobber.lib.tests import run_tests
from typing import NoReturn


def unique_hosts(hosts: str) -> str:
Expand Down Expand Up @@ -292,7 +291,7 @@ def load_from_config(config_path: str) -> Namespace:
return Namespace(**settings)


def save_config(args: Namespace) -> NoReturn:
def save_config(args: Namespace) -> None:
"""
Save the settings as JSON.

Expand Down Expand Up @@ -358,7 +357,7 @@ def load_settings(args: Namespace) -> Namespace:
return args


def execute_command(args: Namespace, version: str) -> NoReturn:
def execute_command(args: Namespace, version: str) -> None:
"""
Execute a specific command from Bobber.

Expand Down Expand Up @@ -393,7 +392,7 @@ def execute_command(args: Namespace, version: str) -> NoReturn:
run_tests.test_selector(args, version_underscore)


def main() -> NoReturn:
def main() -> None:
"""
Launch a test with the Bobber framework.

Expand Down