Skip to content

fix(fio): IOPS parser drops decimal values with '\d+' regex (+1 more) - #95

Closed
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/fio-assorted-802d82e9
Closed

andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/fio-assorted-802d82e9

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

This PR addresses 2 issues in bobber/lib/analysis/fio.py.

Fix 1

fix: IOPS parser drops decimal values with '\d+' regex

Fix: Replace:

    number = float(re.findall(r'\d+', iops)[0])

with:

    number = float(re.findall(r'[-+]?\d+(?:\.\d+)?', iops)[0])

Fix 2

fix: missing IOPS logs are treated as zero instead of skipped

Fix: Replace:

        write_iops = fio_iops_results(log_contents, systems, 'write: IOPS=.*',
                                      log)
        read_iops = fio_iops_results(log_contents, systems, 'read: IOPS=.*',
                                     log)
        write_system_results[systems].append(sum(write_iops))
        read_system_results[systems].append(sum(read_iops))

with:

        write_iops = fio_iops_results(log_contents, systems, 'write: IOPS=.*',
                                      log)
        if write_iops == []:
            continue
        read_iops = fio_iops_results(log_contents, systems, 'read: IOPS=.*',
                                     log)
        if read_iops == []:
            continue
        write_system_results[systems].append(sum(write_iops))
        read_system_results[systems].append(sum(read_iops))

Files changed

  • bobber/lib/analysis/fio.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review July 28, 2026 00:37
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: sole commit is missing a valid Signed-off-by trailer. It does not meet the sweep requirements (single signed-off commit).

@andrewwhitecdw
andrewwhitecdw force-pushed the bugfix/fio-assorted-802d82e9 branch 3 times, most recently from dddfd05 to a1921b5 Compare August 24, 2026 18:16
Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this upstream PR — it was opened by automation without the required sweep-approved review and therefore does not comply with the sweep policy. A replacement fork-local PR is open at andrewwhitecdw#11 for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant