Repository navigation
Probe manual nodes for llmman on 17434 as an Ollama-API engine - #15
ericcurtin wants to merge 4 commits into
Conversation
|
Thanks for opening this up and for your interest in PAIR! We're going to look into this and decide whether or not we want to bring this in. |
@Noah-Tervalon-Nvidia cool, any feedback let me know |
llmman (https://github.com/llmmanorg/llmman) serves the Ollama API on 17434, but manual nodes were only probed for Ollama on 11434, so a node running llmman showed no inference engine. Retry the probe on 17434 and report the answering port in ollama_port; the broker and ollama-proxy already honour that field, so nothing else changes. Ollama wins when both answer. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Rebased onto develop. |
|
@Noah-Tervalon-Nvidia @ckelseynv Rebased and added the release intent block, PTAL. Thank you! |
|
@nv-pgoode @kjlubick PTAL when you get a chance. Thank you! |
|
We are currently trying to get some other big changes in for the next release so most external PRs are on pause for a few days. |
|
Thanks for the update, no rush. |
|
Thanks for the update. If useful, please try https://github.com/llmmanorg/llmman when you get a chance. |
|
@Noah-Tervalon-Nvidia @kjlubick Gentle ping, PTAL when you get a chance. Thank you! |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Merged develop and made the new test table-driven with testify (af74c6d). @nv-pgoode @ckelseynv PTAL when you get a chance. Thank you! |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@Noah-Tervalon-Nvidia @kjlubick PTAL when you get a chance. There are no conflicts and tests pass. Thank you! |
Hi, sorry, I've been out on vacation - the code looks fine. Before we add checks for llmman, can you give us some info about usage of llmman? How many people actively use this? One of the things we're worried about is bringing in something that has a smaller user base and then having to manage maintaining it in our code base. |
|
Thanks Noah. llmman started in March 2026 and has 575 stars and 69 forks. Its release assets have about 73k downloads, but that includes CI and repeat installs, and I have no telemetry on active users. The change is a small fallback probe and I am happy to maintain it. Please close it if the user base is too small for now. |
|
Thanks for the info, we're going to focus on larger backends for now, but we really appreciate your interest in PAIR! |
Description
Changelog title
Probe llmman on port 17434 for manual nodes
Changelog body
Bumps
llmman is a local model runner that serves the Ollama API on port 17434. Manual nodes were probed for Ollama on
11434only, so a device running llmman was reported as having no inference engine even thoughollama-proxycan route to it unchanged.manager.go:probeOllamaAPItries11434then17434and reports the answering port inollama_port; Ollama wins when both answer.11434literals become anollamaPortconstant.ollama_portis already forwarded toollama-proxy, which already dials it. llmman is not added as a new engine type, per CONTRIBUTING.manager_test.go:TestProbeOllamaAPIFallsBackToLLMMancovers Ollama-wins, llmman-only and neither.Scope
In: probing llmman on its default port, docs, test, version bump. Out: llmman as a managed local engine, mDNS-discovered nodes, non-default ports.
Validation
Testing:
gofmt -l .,go vet ./...,go test ./... -count=1inservices/nvpair-manual-nodesandservices/nvpair-ui-broker- clean (macOS arm64, Go 1.26). Not run against a live llmman/Ollama through the full broker/proxy path.Risk
IPC shapes unchanged;
ollama_portmay now be17434. One extra plain-HTTP probe per node per cycle when11434does not answer.Checklist
git commit -s), certifying the Developer Certificate of Origin.services/versions.jsonis written by automation, not edited by hand.