Repository navigation
Conversation
Signed-off-by: yifeif <277870278+yifeif-nv@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Keep the released 27B CLEF cases in Internal/Nightly qualification while marking their Community GPU scope explicitly. Preserve their premerge declarations, inputs, model code, and numerical criteria. Allow the generic boolean CI metadata in the closed manifest contract without a family list. The Dev planner must report these cases as deferred and run its required shared baseline; deferral is not a CLEF model passing result. Signed-off-by: yifeif <277870278+yifeif-nv@users.noreply.github.com>
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Community CI stages checkpoints before launching credential-free GPU containers, but Clef's fixture still queried Hub metadata in offline mode. The subsequent L4 run got past lookup and Docker reported OOM during validation. The selected checkpoint is the complete 27B Clef release, outside the intended small-model Community scope.
Exit Criteria
Consume staged checkpoints without metadata requests. Explicitly defer the three premerge 27B cases from Community while retaining their original validation for the existing Internal/Nightly lanes. Community must still execute real GPU baseline cases and show Clef as deferred, not passed.
Implementation
The family fixture passes
local_files_onlyaccording to the offline environment. Three 27B cases now declarecommunity_gpu: false; a generic metadata check accepts only boolean values for that optional field. Model code, inputs, references, premerge flags and every original numerical assertion remain unchanged. The deployed Dev planner from #1620 supplies mandatory baseline coverage for an otherwise fully deferred selection.Change categories
Validation
Commands and Results
48765e7d: 5 failed, 1 passed before the lookup fix.python -m pytest families/clef/tests -q -p no:cacheprovider: 20 passed, 9 existing unselected GPU/E2E cases skipped on the final source tree.55417d92passed Stable CPU 37775397380: 1,535 Python tests passed, 2 skipped; 246/246 CTests passed.Hardware, Environment, and Revisions
Final head
a9fa6f565b01fe5836e4f91b60393d5692864760, based on main48765e7df0b7dbbe03a21d8b63f8c58db691ab3d. Local controls used a network-disabled Linux ARM64 CPU container. The historical GPU run used AWS g6.4xlarge / L4 and Devf9343f586d04e7425c8588ee6a60b893921fee86; that older run is not final-head baseline qualification.Not Run / Remaining Gaps
Final-head Dev 37795815020 succeeded on CI
13947f20: 1,540 Python tests passed, 2 skipped; 246/246 CTests passed; all 9 baseline GPU E2Es passed with zero selected skips. Clef was explicitly deferred, with no Clef checkpoint staging or container. The default 64 GiB profile selected AWS g6.4xlarge; both cleanup paths confirmed deletion. The 27B model's complete GPU validation is deliberately outside Community coverage; no Nightly or Internal premerge pass is claimed. This PR does not qualify Clef-Flash or modify #1608's branch.Contributor Self-Review
Notes For Future Readers
Depends on the explicit deferral/baseline policy deployed to Dev in #1620. Preserve the offline lookup behavior when integrating #1608's per-checkpoint fixture. A successful Community status validates its runnable GPU baseline, not the deferred Clef model.
Risk level
Coverage routing changes are explicit. Original model criteria and premerge declarations remain intact, and the generic planner rejects an empty green result by requiring real baseline cases.