Repository navigation
[JUnit] Preserve reports on job submission failure - #1091
Draft
podkidyshev wants to merge 5 commits into
Draft
podkidyshev wants to merge 5 commits into
podkidyshev wants to merge 5 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
podkidyshev
force-pushed
the
ipod/junit-submit-fail
branch
from
October 7, 2026 16:51
f15155f to
3b86492
Compare
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
podkidyshev
force-pushed
the
ipod/junit-submit-fail
branch
from
October 7, 2026 18:23
3b86492 to
d23cf51
Compare
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate enabled reports before aborting on job submission failure. Persist the exception type and message in an optional
execution_errorfield intest-run.toml, so JUnit distinguishes CloudAI errors from workload failures and retains that distinction when regenerating reports. Unattempted iterations and DSE steps remain absent.Test Plan
Verified on macOS with Python 3.14.3 using mocked submissions and offline report generation; no benchmark or remote jobs were run.
uv run --locked --extra dev pytest tests/test_base_runner.py tests/test_cloudaigym.py tests/test_handlers.py tests/test_reporter.py tests/test_cli.py tests/test_api.py tests/test_test_scenario.py— 265 passed.uv run --locked --extra dev pytest tests/test_output.py tests/test_single_sbatch_runner.py tests/systems/slurm/test_runner.py tests/systems/standalone/test_runner.py— 47 passed.uv run --locked --extra dev pre-commit run --files <changed-files>— all applicable checks passed, including pyright, Ruff, and import-linter.JobIdRetrievalErrorand the scheduler error message. Regeneration produced identical results. Original run metadata was preserved and the other evidence files were unchanged.Additional Notes
Depends on #1065. Targets
ipod/fix-final-exp, which owns output finalization and report generation; this PR adds submission-error propagation and JUnit classification. Retarget tomainafter #1065 merges.