Skip to content

[pre-commit.ci] pre-commit autoupdate - #2304

Open
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config
Open

pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config

Conversation

@copy-pr-bot

copy-pr-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mdboom

mdboom commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
/pc/clone/iiMN7YpuTkSqCPCVYmy4Hg/py_env-python3/lib/python3.14/site-packages/numpy/__init__.pyi:737: error: Type statement is only supported in Python 3.12 and greater  [syntax]
Found 1 error in 1 file (errors prevented further checking)

The mypy failure here is because the version of numpy is using a type feature only available in Python 3.12 or later, and we tell mypy we want to support 3.10 or later. mypy used to not care about this problem, but seemingly now it does. We can either pin to an earlier version of numpy, not do this mypy update in this PR, or (maybe) try to exclude that one failure, but I'm not sure it's possible with numpy code we don't control.

/code/cuda_core/cuda/core/graph/_graph_builder.pyx:505:13: Loop control variable 'i' not used within the loop body (if this is intended, start the name with an underscore)

The new cython-lint failure seems legit and easy enough to fix on our end.

@leofang

leofang commented Jul 8, 2026

Copy link
Copy Markdown
Member

Interesting, I don't recall seeing pre-commit.ci sending updates!

updates:
- [github.com/NVIDIA/security-workflows: c736f0454dc99764a66af6b906adfcdfbf621985 → 311c90787ec582866a00862682ae3a2710b3f44c](NVIDIA/security-workflows@c736f04...311c907)
- [github.com/astral-sh/ruff-pre-commit: a56c0b927e6465d37cae3e97d35d4d18ab2b96cd → f12be1ebaa5351c1fc76472de98db2c3446c8253](astral-sh/ruff-pre-commit@a56c0b9...f12be1e)
- [github.com/lycheeverse/lychee: 2bba271688c1abb1503097a064e6c3bc1d1b6a9b → c11d7794e9be55fc57d5ffd35543bf6221799fb3](lycheeverse/lychee@2bba271...c11d779)
- [github.com/pre-commit/mirrors-mypy: 7ff8d35ae36a7d2b968f2f90b4c723e292e594ee → 2834ec6639549dd6796205c8f011dedcd587288b](pre-commit/mirrors-mypy@7ff8d35...2834ec6)
- [github.com/MarcoGorelli/cython-lint: eb2f695bb80387913b8cb1f91ba7ff6cb3026715 → ab2da6b679704305e444ed4ee55431505f29c185](MarcoGorelli/cython-lint@eb2f695...ab2da6b)
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 59bf111 to cd49fff Compare October 5, 2026 23:47

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is very problematic...

Comment thread .pre-commit-config.yaml
# first use (no manual install). Skipped on pre-commit.ci; Pulse CI enforces server-side.
- repo: https://github.com/NVIDIA/security-workflows
rev: c736f0454dc99764a66af6b906adfcdfbf621985 # frozen: v0.4.0
rev: 311c90787ec582866a00862682ae3a2710b3f44c # frozen: v0.4.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong, not sure why the bot would update the SHA here?
https://github.com/NVIDIA/security-workflows/releases/tag/v0.4.0

Comment thread .pre-commit-config.yaml
# Link checking for authored documentation files
- repo: https://github.com/lycheeverse/lychee
rev: 2bba271688c1abb1503097a064e6c3bc1d1b6a9b # frozen: lychee-v0.24.2
rev: c11d7794e9be55fc57d5ffd35543bf6221799fb3 # frozen: nightly

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also wrong, 0.24.2 is the latest version

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .pre-commit-config.yaml

- repo: https://github.com/MarcoGorelli/cython-lint
rev: "eb2f695bb80387913b8cb1f91ba7ff6cb3026715" # frozen: v0.21.1
rev: "ab2da6b679704305e444ed4ee55431505f29c185" # frozen: v0.21.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, the SHA shouldn't be updated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants