Skip to content

[no-ci] ci: initialize CCCL for rendered Lychee checks - #3099

Merged
rwgk merged 1 commit into
mainfrom
rwgk/maint/lychee-cccl-submodule
Oct 13, 2026
Merged

rwgk merged 1 commit into
mainfrom
rwgk/maint/lychee-cccl-submodule

Conversation

@rwgk

@rwgk rwgk commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

The rendered Lychee job fails before checking links because its Pixi documentation environment builds cuda-core from source without the CCCL submodule introduced in #2940. The first cache-warming run on main exposed this in the failed rendered job.

Initialize the pinned submodule during checkout for the rendered matrix job. The authored-documentation job does not build cuda-core and keeps its existing checkout behavior. This is a focused follow-up to #2993 and #2652.

Validation on 183bd07:

After merging, dispatch a fresh lychee.yml run on main with refresh-cache=true to publish the shared rendered cache. Branch validation publishes a cache scoped to the PR branch.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rwgk rwgk added this to the cuda.core next milestone Oct 13, 2026
@rwgk rwgk added the CI/CD CI/CD infrastructure label Oct 13, 2026
@rwgk rwgk self-assigned this Oct 13, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk changed the title ci: initialize CCCL for rendered Lychee checks [no-ci] ci: initialize CCCL for rendered Lychee checks Oct 13, 2026
@rwgk
rwgk marked this pull request as ready for review October 13, 2026 21:41
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 9a4d9b1b-6e3e-4f76-8531-9734adaa2cef
📥 Commits

Reviewing files that changed from the base of the PR and between 4e085e1 and 183bd07.

📒 Files selected for processing: 1
  • .github/workflows/lychee.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Rendered link checks now fetch submodules during checkout.

The Lychee workflow now fetches submodules for rendered documentation jobs and omits them for authored jobs.

Changes: Lychee workflow checkout

Layer / File(s) Summary
Conditional submodule checkout
.github/workflows/lychee.yml
The checkout step fetches submodules when matrix.kind is rendered. It does not fetch submodules when matrix.kind is authored.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 183bd

The change limits submodule checkout to rendered documentation jobs. No actionable merge-blocking risk remains in the supplied review.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

2 similar comments
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 9a4d9b1b-6e3e-4f76-8531-9734adaa2cef
📥 Commits

Reviewing files that changed from the base of the PR and between 4e085e1 and 183bd07.

📒 Files selected for processing: 1
  • .github/workflows/lychee.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Rendered link checks now fetch submodules during checkout.

The Lychee workflow now fetches submodules for rendered documentation jobs and omits them for authored jobs.

Changes: Lychee workflow checkout

Layer / File(s) Summary
Conditional submodule checkout
.github/workflows/lychee.yml
The checkout step fetches submodules when matrix.kind is rendered. It does not fetch submodules when matrix.kind is authored.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 183bd

The change limits submodule checkout to rendered documentation jobs. No actionable merge-blocking risk remains in the supplied review.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 9a4d9b1b-6e3e-4f76-8531-9734adaa2cef
📥 Commits

Reviewing files that changed from the base of the PR and between 4e085e1 and 183bd07.

📒 Files selected for processing: 1
  • .github/workflows/lychee.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Rendered link checks now fetch submodules during checkout.

The Lychee workflow now fetches submodules for rendered documentation jobs and omits them for authored jobs.

Changes: Lychee workflow checkout

Layer / File(s) Summary
Conditional submodule checkout
.github/workflows/lychee.yml
The checkout step fetches submodules when matrix.kind is rendered. It does not fetch submodules when matrix.kind is authored.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 183bd

The change limits submodule checkout to rendered documentation jobs. No actionable merge-blocking risk remains in the supplied review.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@rwgk
rwgk enabled auto-merge (squash) October 13, 2026 21:48
@rwgk
rwgk merged commit f4a9d45 into main Oct 13, 2026
36 of 37 checks passed
@rwgk
rwgk deleted the rwgk/maint/lychee-cccl-submodule branch October 13, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants