Repository navigation
Conversation
rwgk
added
enhancement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
the
cuda.core
|
/ok to test 1908aa8 |
|
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Inline explanation of the rename-related changes in the docs-helper test.
| @@ -23,8 +23,26 @@ def test_checking_build_uses_final_local_output_as_docs_domain(tmp_path, monkeyp | |||
| helper.parent.mkdir(parents=True) | |||
| shutil.copyfile(BUILD_HELPER, helper) | |||
|
|
|||
There was a problem hiding this comment.
codex GPT-6.1-Sol ultra explanation for the changes in this file:
These changes make the existing docs-helper test exercise the source-directory mapping affected by this PR.
The helper checks that cuda.bindings, cuda.core, and cuda.pathfinder are imported from this checkout and that their versions agree with installed distribution metadata. Previously, it inferred each source directory from the distribution name by replacing hyphens with underscores. That inference stops working for bindings after this rename:
Distribution: cuda-bindings
Python import: cuda.bindings
Source directory: cuda_bindings_13
The helper now records the source directories explicitly. To cover that change, this test needs to execute the helper's import checks.
Previously, the test's fake python executable intercepted python - (execute a program from standard input), discarded the program with cat >/dev/null, and returned success. That bypassed the entire import-checking block. Leaving that stub in place would let the test pass even if the helper still expected the old cuda_bindings/ directory.
The added setup creates minimal Python packages under the expected source directories, supplies matching .dist-info/METADATA, and exposes those directories through PYTHONPATH. Removing the python - interception then lets the real interpreter execute the helper's checks against this temporary checkout.
Package installation remains stubbed out, and documentation generation remains simulated, so the test still runs without CUDA or Sphinx. Its existing assertions about the docs domain and copied output remain in place; it now also fails if the helper uses the wrong source directory.
|
/ok to test 8349c46 |
This branch has not been deployed
1 participant
Rename the CUDA 13 bindings source root from
cuda_bindings/tocuda_bindings_13/and update its build, test, CI, documentation, and tooling paths.Stacked on #3118 so links to renamed source paths can be checked before merge.
First preparatory step for #1199, following #2737.
Validation: CUDA 13.4 TestVenv QA; 245 CI-tool tests plus 36 subtests; 17 pinned-Lychee regression probes; full pre-commit. CI.