Skip to content

Last 3.15 changes - #3121

Open
mdboom wants to merge 1 commit into
NVIDIA:mainfrom
mdboom:last-3.15-changes
Open

mdboom wants to merge 1 commit into
NVIDIA:mainfrom
mdboom:last-3.15-changes

Conversation

@mdboom

@mdboom mdboom commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Some last straggling changes related to Python 3.15 support from this review comment:
#3113 (review)

@github-actions github-actions Bot added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Oct 15, 2026
@mdboom mdboom self-assigned this Oct 15, 2026
@mdboom mdboom added this to the cuda.core next milestone Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: fc66e8b1-5682-48b8-a089-a5e47046f839
📥 Commits

Reviewing files that changed from the base of the PR and between 166cd5a and 1f16767.

📒 Files selected for processing: 3
  • ci/test-matrix.yml
  • cuda_bindings/pyproject.toml
  • cuda_core/pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded Linux CI coverage to include Python 3.15 with CUDA 12.9.1 and an L4 GPU.
    • Updated test dependency version constraints to allow newer compatible releases and resolve across environments.
    • These updates broaden automated testing coverage and flexibility; they do not change application behavior.

The Linux pull-request matrix adds an amd64 Python 3.15 job. The NumPy and ml-dtypes test dependencies no longer have their previous upper bounds or environment exclusions.

Changes: Python 3.15 Testing

Layer / File(s) Summary
Python 3.15 test coverage and dependency resolution
ci/test-matrix.yml, cuda_bindings/pyproject.toml, cuda_core/pyproject.toml
The CI matrix adds an amd64 Python 3.15 job with CUDA 12.9.1, non-local CTK, one L4 GPU, and the latest driver. The NumPy dependency keeps its >=1.21.1 minimum without an upper bound. The ml-dtypes dependency keeps its >=0.5.4 minimum without an upper bound or environment marker.

Suggested reviewers: leofang

Priority: ⬇️ Low

Change: Feature

Merge Risk: ⚪ Minimal · up to 1f167

The Python 3.15 test and dependency changes show no demonstrated merge-blocking failure; the PR appears mergeable after normal checks.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Comment thread ci/test-matrix.yml
- { ARCH: 'amd64', PY_VER: '3.14t', CUDA_VER: '13.4.2', LOCAL_CTK: '1', GPU: 'l4', GPU_COUNT: '1', DRIVER: 'latest' }
- { ARCH: 'amd64', PY_VER: '3.15', CUDA_VER: '12.9.1', LOCAL_CTK: '0', GPU: 'l4', GPU_COUNT: '1', DRIVER: 'latest' }
- { ARCH: 'amd64', PY_VER: '3.15', CUDA_VER: '13.4.2', LOCAL_CTK: '0', GPU: 'l4', GPU_COUNT: '1', DRIVER: 'latest' }
- { ARCH: 'amd64', PY_VER: '3.15t', CUDA_VER: '13.4.2', LOCAL_CTK: '0', GPU: 'l4', GPU_COUNT: '1', DRIVER: 'latest' }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be better if we also convert 3.15t + CUDA 12.9

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, Mike, not sure why we missed this, but the same expansion should be applied to linux-aarch64 and win-64 too

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants