Skip to content

fix(cuda_core): use nvJitLink-compatible 0/1 values for boolean linker options #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lijinf2 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(cuda_core): use nvJitLink-compatible 0/1 values for boolean linker options #3128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5afde
fix: use nvJitLink-compatible 0/1 values for boolean options (nvbug 6…
lijinf2 Oct 16, 2026
c539cc2
refactor: drop explanatory comment on split_compile int coercion
lijinf2 Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cuda_core/cuda/core/_linker.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,13 +400,13 @@ class LinkerOptions:
if self.lineinfo:
options.append("-lineinfo")
if self.ftz is not None:
options.append(f"-ftz={'true' if self.ftz else 'false'}")
options.append(f"-ftz={'1' if self.ftz else '0'}")
if self.prec_div is not None:
options.append(f"-prec-div={'true' if self.prec_div else 'false'}")
options.append(f"-prec-div={'1' if self.prec_div else '0'}")
if self.prec_sqrt is not None:
options.append(f"-prec-sqrt={'true' if self.prec_sqrt else 'false'}")
options.append(f"-prec-sqrt={'1' if self.prec_sqrt else '0'}")
if self.fma is not None:
options.append(f"-fma={'true' if self.fma else 'false'}")
options.append(f"-fma={'1' if self.fma else '0'}")
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if self.kernels_used is not None:
if isinstance(self.kernels_used, str):
options.append(f"-kernels-used={self.kernels_used}")
Expand All @@ -428,9 +428,9 @@ class LinkerOptions:
for opt in self.ptxas_options:
options.append(f"-Xptxas={opt}")
if self.split_compile is not None:
options.append(f"-split-compile={self.split_compile}")
options.append(f"-split-compile={int(self.split_compile)}")
if self.split_compile_extended is not None:
options.append(f"-split-compile-extended={self.split_compile_extended}")
options.append(f"-split-compile-extended={int(self.split_compile_extended)}")
if self.no_cache is True:
options.append("-no-cache")

Expand Down
2 changes: 1 addition & 1 deletion cuda_core/tests/test_linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def test_linker_options_as_bytes_nvjitlink():
options_str = [opt.decode() for opt in nvjitlink_options]
assert "-arch=sm_80" in options_str
assert "-g" in options_str
assert "-ftz=true" in options_str
assert "-ftz=1" in options_str
assert "-maxrregcount=32" in options_str


Expand Down
Loading