Skip to content

ci: run Lychee through pre-commit in development and CI - #3130

Draft
rwgk wants to merge 2 commits into
rwgk/lychee-check-checkout-linksfrom
rwgk/lychee-through-pre-commit
Draft

ci: run Lychee through pre-commit in development and CI#3130
rwgk wants to merge 2 commits into
rwgk/lychee-check-checkout-linksfrom
rwgk/lychee-through-pre-commit

Conversation

@rwgk

@rwgk rwgk commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Alternative follow-up to #3118 for the team's review: use pre-commit as the common entry point for Lychee in development and CI. Native hook installation and Windows portability are reviewed separately in #3135.

The alternative is isolated in the hook/tooling commit and the CI integration commit.

What changes

  • PR checks on Linux and Windows run the real Lychee hook against the repository. They restore the shared URL cache, warm only Lychee with up to three attempts, then run full pre-commit once as the final gate.
  • Nightly builds fresh authored and rendered caches through the configured hooks. Linux pre-commit runs on main also publish successful authored checks. PRs restore caches or run cold.
  • Rendered HTML and anchors remain checked after the docs build through a manual hook using the same pinned native wheel and shared wrapper.
  • Remove the separate Lychee action, duplicate authored scan in the docs job, and synthetic fixture runner.

Deliberate boundaries

The final authored check uses normal pre-commit's strict verdict, including unresolved HTTP 429s. Rendered checks retain their existing bounded rate-limit allowance. Setup, execution, empty-report, and malformed-report failures remain errors; genuine unresolved links remain advisory during nightly cache warming.

Keep the current one-day URL expiration. Automatic recovery triggers and PR-specific cache publishing are deferred. The CUDA bindings directory rename remains a separate draft in #3116.

Details: CI documentation.

Validation

After extraction: all 287 CI-tool tests plus 36 subtests and full pre-commit pass locally. Both rebuilt layers preserve their prior complete file contents plus the current-main changes. Hosted runs below predate this extraction; new CI is intentionally deferred for web review with [skip ci].

Earlier validation:

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Oct 16, 2026
@rwgk rwgk added the enhancement Any code-related improvements label Oct 16, 2026
@rwgk rwgk self-assigned this Oct 16, 2026
@rwgk rwgk added this to the cuda.bindings next milestone Oct 16, 2026
@rwgk
rwgk added this pull request to stack #3131 October 16, 2026 05:57
@rwgk

rwgk commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 5b82526

@github-actions

github-actions Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-3130/

https://nvidia.github.io/cuda-python/pr-preview/pr-3130/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-3130/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-3130/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from 5b82526 to 399318e Compare October 16, 2026 15:23
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from 399318e to f79ee16 Compare October 16, 2026 15:24
@rwgk rwgk mentioned this pull request Oct 16, 2026
Merged
2 tasks done
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from f79ee16 to 7b62033 Compare October 16, 2026 15:51
@rwgk
rwgk removed this pull request from stack #3131 October 16, 2026 15:52
@rwgk
rwgk added this pull request to stack #3136 October 16, 2026 15:52
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from 7b62033 to 35f3961 Compare October 16, 2026 16:51
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from 35f3961 to 7833762 Compare October 16, 2026 17:47
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch 2 times, most recently from 7c07de0 to c3f881d Compare October 16, 2026 18:25
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from c3f881d to d79b561 Compare October 16, 2026 18:53
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from d79b561 to ddb4d36 Compare October 16, 2026 21:41
rwgk added 2 commits October 16, 2026 15:26
@rwgk
ci: share native Lychee hooks and retry reporting through pre-commit …
87a791a 
…[skip ci]

Use the configured native hooks for authored and rendered checks, collecting strict native reports across pre-commit chunks and applying the existing retry policies.

Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
@rwgk
ci: exercise real Lychee hooks in PR checks and nightly [skip ci]
fd213fe 
Restore shared URL baselines, warm only Lychee with bounded retries, and run the full suite once. Nightly builds authored and rendered caches through the same hooks; remove the separate action and synthetic fixture runner.

Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
@rwgk
rwgk force-pushed the rwgk/lychee-through-pre-commit branch from ddb4d36 to fd213fe Compare October 16, 2026 22:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rwgk rwgk

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module enhancement Any code-related improvements

Projects

None yet

Milestone

cuda.bindings next

Development

Successfully merging this pull request may close these issues.

1 participant

@rwgk