Repository navigation
cuda.bindings: rename CUDA 13 source root to cuda_bindings_13 #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,13 +122,13 @@ jobs: | |
| # | ||
| # Dependency graph (verified in pyproject.toml files): | ||
| # cuda_pathfinder -> (no internal deps) | ||
| # cuda_bindings -> cuda_pathfinder | ||
| # cuda_core -> cuda_pathfinder, cuda_bindings | ||
| # cuda_python -> cuda_pathfinder, cuda_bindings, cuda_core (meta package) | ||
| # cuda_bindings_13 -> cuda_pathfinder | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This dependency graph (lines 125-131) is package-level — it's "verified in pyproject.toml files" — and the |
||
| # cuda_core -> cuda_pathfinder, cuda_bindings_13 | ||
| # cuda_python -> cuda_pathfinder, cuda_bindings_13, cuda_core (meta package) | ||
| # | ||
| # A change to cuda_pathfinder (or shared infra) forces a rebuild of every | ||
| # downstream module. A change to cuda_bindings forces rebuild of cuda_core. | ||
| # A change to cuda_core alone skips rebuilding/retesting cuda_bindings and | ||
| # downstream module. A change to cuda_bindings_13 forces rebuild of cuda_core. | ||
| # A change to cuda_core alone skips rebuilding/retesting cuda_bindings_13 and | ||
| # cuda_pathfinder, but still retests the downstream cuda-python metapackage. | ||
| # Shared build/orchestration changes run the full pipeline; test-only CI | ||
| # infrastructure runs every test suite without rebuilding package wheels. | ||
|
|
@@ -477,7 +477,7 @@ jobs: | |
| python-versions: ${{ needs.ci-vars.outputs.PYTHON_SUPPORTED }} | ||
|
|
||
| # NOTE: test-sdist jobs are split by platform (mirroring build-* and test-wheel-*) | ||
| # so platform-specific sources (e.g. cuda_bindings/*_windows.pyx selected by | ||
| # so platform-specific sources (e.g. cuda_bindings_13/*_windows.pyx selected by | ||
| # build_hooks.py) are exercised on their target OS. Keep these job definitions | ||
| # textually identical except for: | ||
| # - host-platform value | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now reads as self-contradictory (
cuda_bindings_13... "in its cu12 environment"). The statement is about the bindings package lacking a cu12 source build, socuda.bindings/cuda-bindingsis clearer than the_13directory name.