Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test f4f7959 |
1 of 12 tasks
Contributor
Author
|
/ok to test 72a1e10 |
Contributor
Author
|
/ok to test 57efb6d |
…stop if the test binary fails to build
The pinned host memory resource behind cuvsRMMHostAlloc/cuvsRMMHostFree was a thread_local std::unique_ptr that was only created on the first cuvsRMMHostAlloc call of each thread. Freeing a buffer on any other thread dereferenced a null pointer. pinned_host_memory_resource is stateless, so use a single process-wide instance instead.
adjust_centers() advanced a function-local static counter with a plain read-modify-write. Concurrent builds (IVF-Flat, IVF-PQ, ...) from several host threads, each with its own resources, raced on it.
… rust-build this round
Contributor
Author
|
/ok to test d9e5779 |
This was referenced Oct 11, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction PR for #2233 (Rust
cargo testwith default parallel test threads intermittently SIGSEGVs). Part of #2783.CI-only changes:
pr.yamlreduced toconda-cpp-build(amd64, latest CUDA) and 4 copies ofrust-build(2x rtxpro6000, 2x l4).ci/stress_rust.shloops thecuvslib test binary with default, 8, 16, 32 and 64 test threads (some iterations under gdb), plus#[ignore]d multi-thread stress tests where each thread owns its ownResources, and a compute-sanitizer memcheck pass.