Skip to content

Remove fatbin linker script from libcuvs builds - #2871

Open
robertmaynard wants to merge 2 commits into
NVIDIA:mainfrom
robertmaynard:remove-fatbin-linker-script
Open

robertmaynard wants to merge 2 commits into
NVIDIA:mainfrom
robertmaynard:remove-fatbin-linker-script

Conversation

@robertmaynard

Copy link
Copy Markdown
Contributor

Verified that both Debug and RelWithDebInfo builds with CMAKE_CUDA_ARCHITECTURES=RAPIDS work as expected without the .nvFatBinSegment/.nv_fatbin placement script.

This will make it easier to support different linkers with RAPIDS in the future.

Verified that both Debug and RelWithDebInfo builds with
CMAKE_CUDA_ARCHITECTURES=RAPIDS work as expected without the
.nvFatBinSegment/.nv_fatbin placement script.
@robertmaynard
robertmaynard requested a review from a team as a code owner October 16, 2026 13:00
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change ci labels Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuvs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: e19825f5-8781-480e-b074-3bad0a4104de
📥 Commits

Reviewing files that changed from the base of the PR and between 60451af and a4f50fc.

📒 Files selected for processing: 1
  • cpp/CMakeLists.txt
💤 Files with no reviewable changes: 1
  • cpp/CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Build
    • Shared-library builds no longer generate or use an additional linker script during linking. Static-library builds retain their existing linker configuration. This update changes build behavior only; no public interfaces or end-user application features are affected. The existing linker configuration for static libraries is unchanged, and no new functionality or changes to the user experience are included.

The CMake configuration no longer generates fatbin.ld or passes it as a host-link option for the shared cuvs target. The static target’s link option remains unchanged.

Changes: Shared Target Linking

Layer / File(s) Summary
Shared target linker option
cpp/CMakeLists.txt
Removes fatbin.ld generation and the host-link option for the shared cuvs target. The static target’s separate link option remains.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Suggested reviewers: bdice

Merge Risk: ⚪ Minimal · up to a4f50

This change removes a linker script from shared libcuvs builds so other linkers are easier to support later. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: removing the fatbin linker script from libcuvs builds.
Description check Passed The description directly relates to the changeset. It reports successful Debug and RelWithDebInfo builds and explains the benefit of removing the placement script.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci feature request New feature or request non-breaking Introduces a non-breaking change

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

2 participants