Skip to content

CI: Skip devcontainer build for changes that don't affect it - #2875

Open
robertmaynard wants to merge 1 commit into
NVIDIA:mainfrom
robertmaynard:skip-devcontainer-unneeded
Open

robertmaynard wants to merge 1 commit into
NVIDIA:mainfrom
robertmaynard:skip-devcontainer-unneeded

Conversation

@robertmaynard

Copy link
Copy Markdown
Contributor

Port of NVIDIA/cudf#24650. The devcontainer job had no changed-files condition, so it ran on docs-only PRs.

Port of NVIDIA/cudf#24650. The devcontainer job had no changed-files condition, so it ran on docs-only PRs.
@robertmaynard
robertmaynard requested a review from a team as a code owner October 16, 2026 19:36
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change ci labels Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuvs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: e55e4928-1a22-4df6-9f07-b4928df92753
📥 Commits

Reviewing files that changed from the base of the PR and between e7ef1c5 and 98cc4ac.

📒 Files selected for processing: 1
  • .github/workflows/pr.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Development environment builds now run only when relevant project files change.

The pull request adds changed-file detection for devcontainer build inputs. The devcontainer job now waits for changed-files and runs only when the input group matches.

Changes: Devcontainer build gating

Layer / File(s) Summary
Detect inputs and gate the job
.github/workflows/pr.yaml
The workflow adds a changed-file group for devcontainer build inputs, excluding Markdown files. The devcontainer job depends on changed-files and runs only when the group is truthy.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 98cc4

The devcontainer job is gated by the configured build-input changes, and its filter output is wired through. No concrete merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: skipping devcontainer builds when changes do not affect them.
Description check Passed The description accurately explains that the change adds a changed-files condition to prevent devcontainer jobs from running on docs-only pull requests.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bdice

bdice commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci feature request New feature or request non-breaking Introduces a non-breaking change

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

2 participants