Repository navigation
[Documentation] Further Clean-Up Website + Auto-Doc API Tooling - #727
Conversation
Signed-off-by: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com>
[Medium impact] The PR appears safe to merge, with two non-blocking findings from the previous review still open. FindingsSummaryThis PR replaces manual API references with generated documentation, adds the Minimal T2V tutorial app and Wan adapter, and reorganizes website guides.
Reviews (6) · Last reviewed commit: "format" · Reviewed by Greptile |
| PIPELINE_WAN21_T2V_SEED123 = derive_config( | ||
| PIPELINE_WAN21_T2V_1PT3B_480P, | ||
| name="wan21-t2v-1.3b-480p-seed123", | ||
| diffusion_model={"seed": 123}, | ||
| ) |
There was a problem hiding this comment.
Configuration example lacks an import
The example calls derive_config, but integrations_v2/wan21/config.py does not import it. Adding this snippet as instructed makes wan21.config raise NameError, so neither Wan demo can start. Include from flashdreams.infra.config import derive_config in the example.
| PIPELINE_WAN21_T2V_SEED123 = derive_config( | |
| PIPELINE_WAN21_T2V_1PT3B_480P, | |
| name="wan21-t2v-1.3b-480p-seed123", | |
| diffusion_model={"seed": 123}, | |
| ) | |
| from flashdreams.infra.config import derive_config | |
| PIPELINE_WAN21_T2V_SEED123 = derive_config( | |
| PIPELINE_WAN21_T2V_1PT3B_480P, | |
| name="wan21-t2v-1.3b-480p-seed123", | |
| diffusion_model={"seed": 123}, | |
| ) |
|
/ok to test 0b6c72c |
1 similar comment
|
/ok to test 0b6c72c |
|
/ok to test b57dfbf |
|
/ok to test 0ba8eb9 |
| assert "flashdreams.runner_configs" not in manifest["project"]["entry-points"] | ||
| assert "RUNNER_" not in config.read_text() | ||
|
|
||
|
|
There was a problem hiding this comment.
Existing demos lose packaging checks
Deleting test_model_owns_v2_t2v_adapter removes checks that six model packages declare their T2V dependency, include their implementation package, and register the right launch names. Future packaging mistakes could pass CPU checks while leaving a demo unavailable from the command line.
The added Wan adapter makes the old exact-match check too strict. Allow additional launch names while keeping the other checks instead of removing the whole test.
Knowledge Base Used: Standalone text-to-video application
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
/ok to test 45cbf7a |
Related to but does not resolve #565
Changes:
Not Done Yet:
*.md#sectionas single source of truth.