Skip GPU resource validation when device plugin is disabled on the node - #2686
Open
framsouza wants to merge 1 commit into
Open
Skip GPU resource validation when device plugin is disabled on the node#2686framsouza wants to merge 1 commit into
framsouza wants to merge 1 commit into
Conversation
framsouza
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
July 28, 2026 13:16
framsouza
force-pushed
the
fix/2550-skip-plugin-validation-when-disabled
branch
from
July 28, 2026 13:19
4f20986 to
21e948d
Compare
…de. Short-circuit Plugin.validateGPUResource when the node has gpu.deploy.device-plugin=false or resource-allocation.mode=dra, and return without writing plugin-ready. Signed-off-by: Fram Souza <fram.souza14@gmail.com>
framsouza
force-pushed
the
fix/2550-skip-plugin-validation-when-disabled
branch
from
July 28, 2026 13:26
21e948d to
229dcc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvidia-operator-validatoron nodes where the user has intentionally disabled the device plugin vianvidia.com/gpu.deploy.device-plugin=false, by short-circuitingPlugin.validateGPUResourcewith a sentinel error when the label is set.nvidia.com/gpu-operator.resource-allocation.mode=dra, so the classic validator no-ops cleanly on nodes migrated to the DRA stack (belt-and-suspenders during reconciliation windows).Test plan
go vet ./cmd/nvidia-validator/cleango test ./cmd/nvidia-validator/all pass, including 10 new subtestsLocal tests with kind
Kind local tests output