Repository navigation
Keep the Loogle key count when a prediction does not parse - #299
Conversation
A four-key reference plus an unparsed prediction scored 4/5. The miss now keeps the reference key count, so that pair is 4/8. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
please review then @SashaMIT |
|
Reviewed. |
|
Thanks! Could you only keep the updates in |
|
Also, are you planning to use kvpress on the Loogle benchmark ? Or are you reporting a bug reported by a coding agent ? |
Imports stay at module scope, and the extra test file is gone. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
get_exact_match is the only behavior change. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
|
Thanks. The diff is only get_exact_match now. The imports are back at the top of the file, and the test file is gone. I'm not running Loogle. I hit this while reading get_exact_match. An unparsed prediction was counted as 1 instead of the number of keys in the reference. |
|
Thanks for your contribution @SashaMIT |
get_exact_matchcounted a prediction that does not parse as one key. A four-key reference plus that prediction scored 4/5. The miss now keeps the reference key count, so the same pair is 4/8.get_partial_matchalready did this. An unparsable reference still counts as one key.The scorer imports its optional eval packages inside the functions that use them, so this check can run without those packages installed.
No existing issue.
Drafted with Grok 4.7. The code has not yet been reviewed by a human.