Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.
This repository was archived by the owner on May 29, 2026. It is now read-only.

🐛[BUG]: Bugs with ElliCylinder class in primitive_3d.py #264

Closed

Description

@Karl-JT

Version

2.2.0

On which installation method(s) does this occur?

Docker

Describe the issue

In primitive_3d.py from line 1959-1967, the following code provides the bounds for interior_sampling. However the "z" is replaced with "y" in the code and causing errors.

    # calculate bounds
    bounds = Bounds(
        {
            Parameter("x"): (center[0] - a, center[0] + a),
            Parameter("y"): (center[0] - b, center[0] + b),
            Parameter("y"): (center[0] - height / 2, center[0] + height / 2),
        },
        parameterization=parameterization,
    )

Additionally, the ElliCylinder class only allowed for a>b, and it is only specified in a comment in the primitive_3d at line 1669. The customer ran into problem having b>a, but the error message is hard to debug.

Minimum reproducible example

Relevant log output

Environment details

Other/Misc.

No response

Activity

  1. ktangsali commented on Apr 29, 2026

    @ktangsali
    Collaborator

    Closing as part of the archival of this repository. The key components have been upstreamed to NVIDIA/physicsnemo. Please refer to the v2.0 Migration Guide and feel free to re-open your issue there if it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingexternalIssues/PR filed by people outside the core team

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions