Repository navigation
test: make the web evidence browser test opt-in like its siblings - #175
Merged
Merged
Conversation
tests/web-evidence-e2e.test.mjs skipped only when import of playwright failed, so a different Playwright version in an ancestor node_modules made it fail instead of skip. Every sibling browser E2E is opt-in through a RUN_*_E2E variable; use RUN_WEB_EVIDENCE_E2E and set it in the web-evidence-e2e workflow so CI still runs the test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/web-evidence-e2e.test.mjsskipped only whenimport("playwright")failed. The other browser E2E tests are opt-in through aRUN_*_E2Evariable. When a different Playwright version sits in an ancestornode_modules(for example the user profile), the import succeeds and the test fails withunsupported_playwright_versioninstead of skipping.Change
Gate the test on
RUN_WEB_EVIDENCE_E2E=1, the same convention asRUN_WEB_CAPABILITIES_E2E, and set the variable in.github/workflows/web-evidence-e2e.ymlso CI still runs it. A CHANGELOG entry records the new opt-in.Verification
node --test tests/web-evidence-e2e.test.mjs tests/readme-entrypoint.test.mjs: 5 pass, 0 fail, 1 skipped (the E2E is now skipped by default)node scripts/verify-all.mjspassed on the combined branch of all four fixes (95 test files, Windows / Node.js 24.19.0); remote CI runs it here, and the changed workflow runs the E2E with the variable setCompatibility
RUN_WEB_EVIDENCE_E2E=1Security and privacy
Issue
Part of the 2026-10-19 review fixes. Closes no issue.
🤖 Generated with Claude Code