Repository navigation
docs: link one tracked agent orchestration reference and test relative links - #176
Conversation
…e links The Claude agent orchestration link in both READMEs pointed at a generated, git-ignored path, so it was dead on GitHub. The Codex, Claude and shared copies are byte-identical apart from line endings, so one bullet now links the shared source. tests/markdown-links.test.mjs keeps relative Markdown links in tracked files resolvable. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 832eb78d80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const [index, line] of markdown.split(/\r?\n/u).entries()) { | ||
| if (line.startsWith("```")) inFence = !inFence; | ||
| if (inFence) continue; | ||
| for (const match of line.matchAll(/\[[^\]]+\]\((?<target>[^)]+)\)/gu)) { |
There was a problem hiding this comment.
The matcher only recognizes inline links of the form [text](target), so a standard reference-style link such as [guide][docs] with [docs]: missing.md is ignored and the test still passes. A broken relative link can therefore be introduced without triggering the repository-wide safeguard this test claims to provide; parse reference definitions as well or use a Markdown parser.
Useful? React with 👍 / 👎.
Problem
README.mdandREADME.en.mdlinked the Claude agent orchestration reference throughclaude/skills/.../agent-orchestration.md. That directory is generated and git-ignored, so the link was dead on GitHub. The Codex, Claude and shared copies are byte-identical apart from line endings, and the two adjacent bullets pointed at the same content.Change
shared/skill/references/agent-orchestration.md, in both READMEs.tests/markdown-links.test.mjs. It lists tracked files withgit ls-files, scans inline Markdown links outside code fences, and fails when a relative link does not resolve to a tracked file or directory. It skips with a reason when git is unavailable. It partly overlaps the existing README link test and covers every tracked Markdown file.release-files.jsonand a CHANGELOG entry.Verification
node --test tests/markdown-links.test.mjs tests/readme-entrypoint.test.mjs tests/readme-i18n.test.mjs: 12 pass, 0 failnode scripts/verify-all.mjspassed on the combined branch of all four fixes (95 test files, Windows / Node.js 24.19.0); remote CI runs it hereCompatibility
Security and privacy
Issue
Part of the 2026-10-19 review fixes. Closes no issue.
🤖 Generated with Claude Code