Repository navigation
fix: treat artifact paths that differ only in case as duplicates on macOS - #177
Merged
Merged
Conversation
…acOS Duplicate registered artifact paths were folded to lower case only on win32, but the default macOS filesystem is case-insensitive too. Add artifactPathKey with an injectable platform that folds case on win32 and darwin, and use it only for the two duplicate-path checks. Symlink, junction and containment comparisons keep their exact semantics on every platform. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Duplicate registered artifact paths were compared through
pathKey(), which folds case only onwin32. The default macOS filesystem (APFS) is case-insensitive too, so two artifact paths that differ only in case were not detected as duplicates there. The only existing test for this is win32-only, so macOS CI never exercised the rule.Change
artifactPathKey(value, platform = process.platform)tosafe-file-io.mjs. It folds case when the platform iswin32ordarwin, and the platform is injectable for tests.audit-run-validation.mjsand the duplicate check at registration inaudit-run.mjs.tests/artifact-path-identity.test.mjs(platform-injected unit tests) to the tests and torelease-files.json, and a CHANGELOG entry.Verification
node --test tests/artifact-path-identity.test.mjs tests/module-dependency.test.mjs: 13 pass, 0 failnode --test --test-name-pattern="canonical|duplicate" tests/audit-orchestration-cli.test.mjs: 8 pass, 0 failsafe-file-io.mjs,audit-run.mjsoraudit-run-validation.mjs: 253 tests, 0 failnode scripts/verify-all.mjspassed on the combined branch of all four fixes (95 test files, Windows / Node.js 24.19.0); remote CI runs it here, including the macOS cellssync-distributions --checkis clean)Compatibility
Security and privacy
Issue
Part of the 2026-10-19 review fixes (P17 in the internal review). Closes no issue.
🤖 Generated with Claude Code