Repository navigation
fix: honor HTTP negotiation and method contracts - #38
Merged
Merged
Conversation
github-actions
Bot
force-pushed
the
fix/worker-http-contract
branch
from
August 22, 2026 07:43
3c57d18 to
c4b4749
Compare
Nagi-Inaba
commented
Aug 22, 2026
Nagi-Inaba
left a comment
Owner
Author
There was a problem hiding this comment.
現head c4b4749 はDraftのままマージ保留です。実装差分自体にCritical/Highは見つかりませんでしたが、次を解消してください。
- worker/test/http.spec.ts が worker/vitest.config.ts の include: ["test/worker.spec.ts"] に含まれていません。隔離worktreeで npm --prefix worker run verify を実行した結果も、従来どおり main Workerは 1 test file / 31 tests で、新規helper testは0件実行でした。includeへ追加するか、既存worker.spec.tsへ統合してください。
- branch commitがgithub-actions[bot]由来のため、PRにはrequired CI checkが記録されずCodeQLだけです。通常のbranch更新でrequired checksを発火させ、全check成功を確認してください。
- Accept選択とAllow headerは外部HTTP契約の変更です。docs/current-status.mdと適用するarchitecture/traceability文書へ、挙動と検証結果を同期してください。
- issue #23の「q=0を選択対象から除外」と、両representationがq=0またはAcceptが非対応mediaだけの場合にHTMLへfallbackする現在実装の関係を、テストまたは文書で明示してください。
ローカル確認:
- npm --prefix worker ci: 成功、audit 0
- npm --prefix worker run verify: 成功
- Worker 31件 / WebMCP 3件(ただし新規http.spec.tsは未実行)
Nagi-Inaba
marked this pull request as ready for review
August 22, 2026 08:15
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d83b819952
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Workerの表現選択と
AllowヘッダーをHTTP契約に合わせます。Acceptのmedia range・品質値・wildcardを解釈q=0を選択対象から除外Allowへ表示検証
Closes #23