Skip to content

[2026 Testing] Enforce per-file coverage thresholds for critical Stellar and signing modules #1003

Open

Description

@Nanle-code

Objective

Guarantee high test coverage where bugs lose funds or break signing.

Target area

vitest config, scripts/check-coverage.mjs

Context

Global coverage thresholds can hide low coverage in critical files. Stellar SDK wrappers, the transaction builder, fee math, address parsing and signing flows need a higher bar than UI code.

Acceptance criteria

  • Per-file thresholds of ≥90% lines/branches for src/lib/stellar*, transactionBuilder.ts, stroop/amount utilities, src/lib/wallet/** and multisig*.
  • check-coverage.mjs reports per-file failures clearly in the CI summary.
  • Tests are added to meet the thresholds, focused on branches and failure paths.
  • Thresholds are documented in contributor docs.
  • Automated tests cover the primary flow, at least one boundary case, and at least one failure case.
  • User-facing documentation or developer guidance is updated, including compatibility, security, or migration notes where applicable.

Pull request requirements

  • All continuous integration checks must pass before a pull request may be merged.
  • The branch must be free of merge conflicts with the target branch at the time of merge.
  • Do not request merge with failing workflows, skipped required checks, or unresolved conflicts.

Activity

  1. added
    Stellar WaveActive sprint / batch of issues
    securityWallet, auth, or crypto paths; needs a CODEOWNERS review and is never a starter issue
    on Sep 23, 2026
  2. drips-wave commented on Sep 23, 2026

    @drips-wave

    @Nanle-code This issue could not be added to the Stellar Wave Program because the per-repo points budget would be exceeded (25000 / 25000 points already used). The label has been automatically removed.

    The budget resets at the end of each Wave. You can review the remaining budget for your repos on the Orgs & Repos page.

    ℹ️ Learn more about points budgets

  3. Oluwatobi1212 commented on Oct 16, 2026

    @Oluwatobi1212

    @Oluwatobi1212 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    After reviewing the task and its requirements, I believe I can implement a solution that follows the expected design and acceptance criteria.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Oluwatobi1212 to this issue.

  4. yodakkak commented on Oct 16, 2026

    @yodakkak

    /claim #1003

    I'd like to work on this issue and will submit a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Stellar WaveActive sprint / batch of issuesqualitysecurityWallet, auth, or crypto paths; needs a CODEOWNERS review and is never a starter issuetesting

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions